CI: add main tag to Docker image
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
lalver1
force-pushed
the
ci/multiplatform-update
branch
from
fb754cb to
c0702a4
Compare
|
Can you please check out cal-itp/benefits#2616? Can we add back the |
lalver1
force-pushed
the
ci/multiplatform-update
branch
from
c0702a4 to
0ad958a
Compare
lalver1
changed the title
main tag to Docker image
|
I tested using an Apple M2 and I'm pretty sure that's the actual problem @thekaveman, thanks for bringing it up! I updated the PR's description to make this more clear. |
lalver1
force-pushed
the
ci/multiplatform-update
branch
from
0ad958a to
1cfe739
Compare
thekaveman
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Apple M2 users see a
no matching manifest for linux/arm64/v8 in the manifest list entriesmessage when trying to pull theeligibility-serverimage from this repository's associated GHCR and the pull fails.This PR publishes alinux/arm64/v8Docker image so that Apple M2 users can directly pull theeligibility-serverimage.I tested pulling
ghcr.io/cal-itp/eligibility-server:4e1d6c09239ceac913243c61f230fe1c045e2939@sha256:8335d87361c823ccc9eea7a92c28da3fed92c730c4dd33c3a0dbdf27b70f6264using an Apple M2, and the pull succeeded. So, the issue is actually due to the Docker image missing the
maintag. This PR adds amaintag to the Docker image so that it can be pulled directly from the Benefits application (see cal-itp/benefits#2616).