Chore: clean up docker-publish workflow #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
lalver1
force-pushed
the
chore/cleanup-multiplatform
branch
from
bf1b604 to
5d98668
Compare
thekaveman
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
👍 Looks good, follows the pattern established in docker-python-web
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487 and adds support for building a multi-platform image.
Making the image multi-platform will streamline creating the Benefits dev container for Mac users since at the moment
bin/build.shin Benefits attempts to pull theeligibility-serverimage from GHCR, but when anlinux/arm64image isn't found, it returns an error.