Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors on GTFS RT validation #3513

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Fix errors on GTFS RT validation #3513

merged 7 commits into from
Nov 18, 2024

Commits on Nov 18, 2024

  1. Update gtfs-rt-parser-v2 dependencies 

    Signed-off-by: Erika Pacheco <[email protected]>
    @ohrite @erikamov
    ohrite authored and erikamov committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d34c7f4 View commit details
    Browse the repository at this point in the history

  2. Add Typer test to gtfs-rt-parser-v2 

    Signed-off-by: Erika Pacheco <[email protected]>
    @ohrite @erikamov
    ohrite authored and erikamov committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1c2d2b2 View commit details
    Browse the repository at this point in the history

  3. Remove early return from gtfs_rt_parser.py 

    * This simplifies the flow of control so that every command runs the same code

Signed-off-by: Doc Ritezel <[email protected]>
    @erikamov
    erikamov committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    756077b View commit details
    Browse the repository at this point in the history

  4. Add additional characterization tests for gtfs-rt-parser-v2 

    Signed-off-by: Doc Ritezel <[email protected]>
    @erikamov
    erikamov committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4d0b327 View commit details
    Browse the repository at this point in the history

  5. Analyst sees fewer ZLIB errors 

    * This commit resolves a race condition where all parse_and_validate calls shared the same temporary directory
* That contention meant that processes would overwrite the existing GTFS schedule with the same name
* This also resulted in an elevated number of skipped protobuf validations
* The gtfs-realtime-validator skips protobufs with the same MD5
* The race condition caused elevated MD5 collisions for protobufs

Signed-off-by: Doc Ritezel <[email protected]>
    @erikamov
    erikamov committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    bc6b022 View commit details
    Browse the repository at this point in the history

  6. Add additional tests for gtfs-rt-parser-v2 

    [#2780]

Signed-off-by: Doc Ritezel <[email protected]>
    @erikamov @ohrite
    erikamov authored and ohrite committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b9cd359 View commit details
    Browse the repository at this point in the history

  7. Skip tests until we can use GCS on Github Actions. 

    [#2780]

Signed-off-by: Doc Ritezel <[email protected]>
    @erikamov @ohrite
    erikamov authored and ohrite committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    88ed9ad View commit details
    Browse the repository at this point in the history