Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airtable docs updates #2868

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Airtable docs updates #2868

merged 9 commits into from
Aug 10, 2023

Conversation

lauriemerrell
Copy link
Contributor

@lauriemerrell lauriemerrell commented Aug 8, 2023

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

This PR:

  • Updates the Airtable documentation page to:
    • Delete outdated information (especially about the transit data assessments base, which as I understand it is deprecated)
    • Add information about considerations associated with ingesting Airtable data into the data warehouse
  • Rearranges docs navigation:
    • Moves the "navigating the dbt docs" page into the warehouse section and removes the "legacy documentation" section
    • Moves the Transit Database (Airtable) specific docs into the developer section

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Include commands/logs/screenshots as relevant.

N/A - inspected preview link

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@lauriemerrell lauriemerrell changed the title wip updates Airtable docs updates Aug 8, 2023
@lauriemerrell lauriemerrell marked this pull request as ready for review August 8, 2023 17:25
Copy link
Contributor

@SorenSpicknall SorenSpicknall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy with this, so tentatively approving - just one note on a linked reference

docs/transit_database/transitdatabase.md Outdated Show resolved Hide resolved
@lauriemerrell lauriemerrell added the do-not-merge Do not merge, even if approved label Aug 8, 2023
@lauriemerrell lauriemerrell removed the do-not-merge Do not merge, even if approved label Aug 10, 2023
@lauriemerrell
Copy link
Contributor Author

Evan confirmed in Slack this is ok to merge!

@lauriemerrell lauriemerrell merged commit d81d53b into main Aug 10, 2023
3 checks passed
@lauriemerrell lauriemerrell deleted the update-airtable-docs branch August 10, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants