Feat: fallback background color #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
ideally, the user's browser supports WebP and will show the image, but just in case it doesn't, we want the white text to be readable. use the same color as the left side of the background image. this contrast ratio passes WCAG AAA requirements.
angela-tran
force-pushed
the
feat/fallback-background-color
branch
from
d7bb130
to
48995b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2490
This PR will be merged in to #2523.
I think it makes sense for the changes from both PRs to be merged into
maintogether, but I also wanted to have separate code reviews.Fallback background color
I took the color from the left side of the background image and used that as the
background-colorfor the main section of the landing page.The WebAIM contrast checker shows this contrast ratio passes WCAG AAA requirements.
Screenshots of background-color in use (background image does not load)