Refactor: move EligibilityType fields to EnrollmentFlow

[lalver1]

Closes #2283

• Fields from EligibilityType are moved to EnrollmentFlow
• Migrate the data from EligibilityType.name to EnrollmentFlow.name in the migration file
• The label field is used as the Admin display field for EnrollmentFlow instances
• TransitAgency.eligibility_types field (and all related calculated fields) are removed
• EligibilityType model is removed
• session.eligibility_types is removed
• session.eligible (get bool) used to indicate if the user was found eligible for their selected flow, updated through session.update(eligible=bool) like other session data
• EligibilityType read-only fields are moved to the new model
• Analytics events that currently include eligibility_types properties (event/user) now use enrollment_flows.eligibility_name for the eligibility_types property values
• Update tests

Testing locally

1. Checkout the main branch
2. Make sure that your local_fixtures.json (or whatever fixture you are using) has an EnrollmentFlow that has a foreign key reference to an EligibilityType.
3. Run bin/reset_db.sh (now your local DB mirrors the structure of the dev environment)
4. Checkout this PR's branch
5. Run bin/init.sh (running this PR's migration on top of existing DB structure)

[thekaveman]

Looking good, few cleanups needed to keep the analytics consistent for now.

[thekaveman]

benefits/core/migrations/local_fixtures.json needs to be updated to combine the data from the old core.eligibilitytype fixtures into the core.enrollmentflow fixtures. That's (part of the reason) why the Cypress tests are failing.

[lalver1]

These are the only tests that are still failing (they're in enrollment/test_views)

• test_index_eligible_post_valid_form_http_error_500
• test_index_eligible_post_valid_form_http_error_400
• test_index_eligible_post_valid_form_failure

and I'm having a hard time getting them to work. The current state of the PR has the original code (to use as a reference) so these tests still use mocked_session_eligibility and model_EligibilityType, which don't exist anymore, but a simple change of these to mocked_session_eligibility and model_EnrollmentFlow doesn't fix the failing tests so I think a more thorough refactor is needed for these 3 tests 🤔 Or, the views actually have errors but this doesn't seem to be the case since the code in the views only had minor changes and I don't get any errors when running through an enrollment flow locally.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits/core
admin.py
analytics.py
context_processors.py
models.py
session.py
benefits/eligibility
analytics.py
verify.py
views.py					40
benefits/enrollment
views.py
benefits/oauth
middleware.py
Project Total

This report was generated by python-coverage-comment-action

[github-actions]

Preview url: https://benefits-2299--cal-itp-previews.netlify.app

[thekaveman]

-180 for the PR, nice 👍

---

UPDATE:

-182 👍

[thekaveman]

Alright so this is looking great logic-wise! Congrats on getting the tests to pass 🎉

My comments are all stylistic / syntactic in nature, but things we can clean up now since we're doing this refactor.

Nearly there 💪

[thekaveman]

Champion 🌟 🥇 🏆

[lalver1]

Thanks so much!