Fix: terraform plan and apply conditions #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
lalver1
force-pushed
the
fix/terraform-plan-apply-conditions
branch
from
5245bf3
to
bbd4fc6
Compare
lalver1
force-pushed
the
fix/terraform-plan-apply-conditions
branch
from
1f22c94
to
dd57ccc
Compare
angela-tran
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
This reads very nicely and cleanly to me! Nice work @lalver1
thekaveman
approved these changes
Jul 25, 2024
|
Thanks @angela-tran and @thekaveman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #2213. The terraform
planandapplysteps were not running when expected because the conditions on the steps were not evaluating correctly. Contrary to the documentation, we noticed thatparametersdon't get evaluated inconditions. Because of this, even thoughtag_typewas set inTerraform apply, this step wouldn't run when a tag was pushed.This PR fixes this behavior by changing
parameters.tag_typetovariables['tag_type']forTerraform planandTerraform applywhich requires:tag_typefromazure-pipelines.ymlintodeploy.ymlso thattag_typedoesn't get passed as a parameter anymoretag.pyto determine the value ofIS_TAGinstead of an Azure pipeline expression sinceenv:does not support evaluating expressions andvariables:is out of scope indeploy.yaml.