-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Clean up localfixtures, env, Cypress tests to only have CST #2214
Conversation
3ac63e8
to
f0e941d
Compare
@angela-tran Are you able to go through the entire Agency Card flow locally with this fixture file? I'm not currently but it might be because my Elig Server image is messed up. |
I can get through some of it. Here's where I'm at:
Tried to verify Agency Card eligibility, saw an error about
Tried to verify Agency Card eligibility again, was able to see and submit the form, but got the "Your card information may not have been entered correctly." screen, and saw this in
Options to fix:
|
Yes! I was just about to comment that we'll have to also make a ticket to clean up MST/SBMTD-specific data from Elig Server test files too. |
e038bd6
to
abe0eb5
Compare
31e099d
to
4773886
Compare
@angela-tran @thekaveman @lalver1 I decided to do both #2210 #2211 in one PR, because the latter requires the former for it to work, and the former requires the latter for it to pass GitHub tests. I believe once the changes to the server.csv file and associated specs here cal-itp/eligibility-server#484 are merged and deployed, then this PR should then pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good so far. One small request.
@thekaveman Ready for re-review. Tests are now passing! |
e8838b2
to
3a86db1
Compare
"pk": 7, | ||
"fields": { | ||
"name": "(MST) CalFresh oauth claims via Login.gov", | ||
"name": "(CST) CalFresh oauth claims via Login.gov", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not for this PR): eventually we should have a new core.authprovider
instance for this verifier:
{
"model": "core.authprovider",
"pk": 3,
"fields": {
"sign_out_button_template": "core/includes/button--sign-out--login-gov.html",
"sign_out_link_template": "core/includes/link--sign-out--login-gov.html",
"client_name": "calfresh-benefits-oauth-client-name",
"client_id_secret_name": "auth-provider-client-id",
"authority": "https://example.com",
"scope": "verify:calfresh",
"claim": "calfresh",
"scheme": "dev-cal-itp_benefits"
}
},
Then update the field here on the eligibilityverifier
:
- "auth_provider": 1
+ "auth_provider": 3
closes #2210
closes #2211
This work is related to #2209 #2205 and other tickets a part of removing specific real agencies from non-production apps.
What this PR does
.env.sample
fileTesting
Post-merge tasks