Index/Agency-Index: Add rounded corners to mobile box #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
machikoyasuda
changed the title
thekaveman
approved these changes
Aug 1, 2023
| @@ -787,6 +787,7 @@ a.card:focus-visible { | |||
| .landing .box { | |||
| background: var(--landing-box-background); | |||
| border-top: var(--landing-box-border); | |||
| border-radius: calc(8rem / 16); | |||
There was a problem hiding this comment.
Not a blocker, but I just noticed we have a few different ways / places of specifying border-radius, I wonder if we want to consolidate at some point:
- Root variable
--border-radius: calc(3rem / 16)(=3px), used for.signout-linkand.form-container .form-control - Direct 8px rule on
.card - Root variable
--modal-border-radius: 8px;, overridden for wider screens to--modal-border-radius: 4px;, used for.modal-content
And now the one from this PR (=8px).
There was a problem hiding this comment.
Yeah I noticed this too. We can refactor at another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1578