Skip to content

Commit

Permalink
Generic fixes (#1320)
Browse files Browse the repository at this point in the history
* New price API

* Fix test app package id

* Fix workflow

* change environment variable to use pr number [skip ci]

* Fix un-needed padding

* Fix raw value for usdtSol

* Remove duplicate fetching for balance and transactions at start [skip ci]

* Fix address validation of spl tokens

* Add Service Status

* Update lib/src/widgets/service_status_tile.dart

Co-authored-by: Konstantin Ullrich <[email protected]>

* Update lib/src/widgets/services_updates_widget.dart

Co-authored-by: Konstantin Ullrich <[email protected]>

* Update monero version

* update sodium script

* Change automatic priority fee rate

---------

Co-authored-by: Konstantin Ullrich <[email protected]>
  • Loading branch information
OmarHatem28 and konstantinullrich authored Mar 10, 2024
1 parent c7deeae commit 6414364
Show file tree
Hide file tree
Showing 20 changed files with 285 additions and 33 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/pr_test_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
env:
STORE_PASS: test@cake_wallet
KEY_PASS: test@cake_wallet
PR_NUMBER: ${{ github.event.number }}

steps:
- name: is pr
Expand Down Expand Up @@ -150,10 +151,7 @@ jobs:
- name: Rename app
run: |
hash=`sha512sum <<<"${{ env.BRANCH_NAME }}"`
substring=${hash:0:15}
echo substring
echo -e "id=com.cakewallet.test_$(substring)\nname=${{ env.BRANCH_NAME }}" > /opt/android/cake_wallet/android/app.properties
echo -e "id=com.cakewallet.test_${{ env.PR_NUMBER }}\nname=${{ env.BRANCH_NAME }}" > /opt/android/cake_wallet/android/app.properties
- name: Build
run: |
Expand Down
Binary file added assets/images/notification_icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/status_website_image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion cw_core/lib/crypto_currency.dart
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ class CryptoCurrency extends EnumerableItem<int> with Serializable<int> implemen
static const usdcEPoly = CryptoCurrency(title: 'USDC.E', tag: 'POLY', fullName: 'USD Coin (PoS)', raw: 88, name: 'usdcepoly', iconPath: 'assets/images/usdc_icon.png', decimals: 6);
static const kaspa = CryptoCurrency(title: 'KAS', fullName: 'Kaspa', raw: 89, name: 'kas', iconPath: 'assets/images/kaspa_icon.png', decimals: 8);
static const digibyte = CryptoCurrency(title: 'DGB', fullName: 'DigiByte', raw: 90, name: 'dgb', iconPath: 'assets/images/digibyte.png', decimals: 8);
static const usdtSol = CryptoCurrency(title: 'USDT', tag: 'SOL', fullName: 'USDT Tether', raw: 90, name: 'usdtsol', iconPath: 'assets/images/usdt_icon.png', decimals: 6);
static const usdtSol = CryptoCurrency(title: 'USDT', tag: 'SOL', fullName: 'USDT Tether', raw: 91, name: 'usdtsol', iconPath: 'assets/images/usdt_icon.png', decimals: 6);


static final Map<int, CryptoCurrency> _rawCurrencyMap =
Expand Down
11 changes: 4 additions & 7 deletions cw_monero/lib/monero_wallet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,8 @@ abstract class MoneroWalletBase
// try to use the date instead:
try {
_setHeightFromDate();
} catch (e, s) {
} catch (_) {
// we still couldn't get a valid sync height :/
onError?.call(FlutterErrorDetails(
exception: e,
stack: s,
library: this.runtimeType.toString(),
));
}
}
}
Expand Down Expand Up @@ -287,7 +282,9 @@ abstract class MoneroWalletBase
pendingTransactionDescription = await transaction_history.createTransaction(
address: address!,
amount: amount,
priorityRaw: _credentials.priority.serialize(),
priorityRaw: _credentials.priority == MoneroTransactionPriority.automatic
? MoneroTransactionPriority.medium.serialize()
: _credentials.priority.serialize(),
accountIndex: walletAddresses.account!.id,
preferredInputs: inputs);
}
Expand Down
10 changes: 0 additions & 10 deletions cw_solana/lib/solana_wallet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -165,16 +165,6 @@ abstract class SolanaWalletBase
throw Exception("Solana Node connection failed");
}

try {
await Future.wait([
_updateBalance(),
_updateNativeSOLTransactions(),
_updateSPLTokenTransactions(),
]);
} catch (e) {
log(e.toString());
}

_setTransactionUpdateTimer();

syncStatus = ConnectedSyncStatus();
Expand Down
1 change: 1 addition & 0 deletions lib/di.dart
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ Future<void> setup({
yatStore: getIt.get<YatStore>(),
ordersStore: getIt.get<OrdersStore>(),
anonpayTransactionsStore: getIt.get<AnonpayTransactionsStore>(),
sharedPreferences: getIt.get<SharedPreferences>(),
keyService: getIt.get<KeyService>()));

getIt.registerFactory<AuthService>(
Expand Down
1 change: 1 addition & 0 deletions lib/entities/preferences_key.dart
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,5 @@ class PreferencesKey {
static const lastSeenAppVersion = 'last_seen_app_version';
static const shouldShowMarketPlaceInDashboard = 'should_show_marketplace_in_dashboard';
static const isNewInstall = 'is_new_install';
static const serviceStatusShaKey = 'service_status_sha_key';
}
41 changes: 41 additions & 0 deletions lib/entities/service_status.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
class ServiceStatus {
final String title;
final String description;
final String? image;
final String? status;
final DateTime date;

ServiceStatus(
{required this.title,
required this.description,
required this.date,
this.image,
this.status});

factory ServiceStatus.fromJson(Map<String, dynamic> json) => ServiceStatus(
title: json['title'] as String? ?? '',
description: json['description'] as String? ?? '',
date: DateTime.tryParse(json['date'] as String? ?? '') ?? DateTime.now(),
image: json['image'] as String?,
status: json['status'] as String?,
);
}

class ServicesResponse {
final List<ServiceStatus> servicesStatus;
final bool hasUpdates;
final String currentSha;

ServicesResponse(this.servicesStatus, this.hasUpdates, this.currentSha);

factory ServicesResponse.fromJson(
Map<String, dynamic> json, bool hasUpdates, String currentSha) {
return ServicesResponse(
(json['notices'] as List? ?? [])
.map((e) => ServiceStatus.fromJson(e as Map<String, dynamic>))
.toList(),
hasUpdates,
currentSha,
);
}
}
2 changes: 1 addition & 1 deletion lib/solana/cw_solana.dart
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class CWSolana extends Solana {
@override
List<int>? getValidationLength(CryptoCurrency type) {
if (type is SPLToken) {
return [44];
return [32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44];
}

return null;
Expand Down
4 changes: 4 additions & 0 deletions lib/src/screens/dashboard/dashboard_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'package:cake_wallet/src/screens/dashboard/desktop_widgets/desktop_sideba
import 'package:cake_wallet/src/screens/dashboard/pages/market_place_page.dart';
import 'package:cake_wallet/src/screens/wallet_connect/widgets/modals/bottom_sheet_listener.dart';
import 'package:cake_wallet/src/widgets/gradient_background.dart';
import 'package:cake_wallet/src/widgets/services_updates_widget.dart';
import 'package:cake_wallet/src/widgets/vulnerable_seeds_popup.dart';
import 'package:cake_wallet/themes/extensions/sync_indicator_theme.dart';
import 'package:cake_wallet/utils/device_info.dart';
Expand Down Expand Up @@ -101,6 +102,9 @@ class _DashboardPageView extends BasePage {
@override
Widget get endDrawer => MenuWidget(dashboardViewModel);

@override
Widget leading(BuildContext context) => ServicesUpdatesWidget(dashboardViewModel.getServicesStatus());

@override
Widget middle(BuildContext context) {
return SyncIndicator(
Expand Down
2 changes: 1 addition & 1 deletion lib/src/widgets/base_alert_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class BaseAlertDialog extends StatelessWidget {
Column(
crossAxisAlignment: CrossAxisAlignment.center,
children: <Widget>[
if (headerText != null) headerTitle(context),
if (headerText?.isNotEmpty ?? false) headerTitle(context),
Padding(
padding: EdgeInsets.fromLTRB(24, 20, 24, 0),
child: title(context),
Expand Down
71 changes: 71 additions & 0 deletions lib/src/widgets/service_status_tile.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import 'package:auto_size_text/auto_size_text.dart';
import 'package:cake_wallet/entities/service_status.dart';
import 'package:flutter/material.dart';
import 'package:intl/intl.dart';

class ServiceStatusTile extends StatelessWidget {
final ServiceStatus status;

const ServiceStatusTile(this.status, {super.key});

@override
Widget build(BuildContext context) {
return ListTile(
contentPadding: const EdgeInsets.all(8),
title: Padding(
padding: const EdgeInsets.symmetric(vertical: 8),
child: Row(
crossAxisAlignment: CrossAxisAlignment.end,
children: [
Expanded(
child: AutoSizeText(
"${status.title}${status.status != null ? " - ${status.status}" : ""}",
style: TextStyle(
fontSize: 16,
fontFamily: 'Lato',
fontWeight: FontWeight.w800,
height: 1,
),
maxLines: 1,
textAlign: TextAlign.start,
),
),
Text(
_getTimeString(status.date),
style: TextStyle(fontSize: 12),
),
],
),
),
leading: RotatedBox(
child: Icon(
Icons.info,
color: status.status == "resolved" ? Colors.green : Colors.red,
),
quarterTurns: 2,
),
subtitle: Row(
children: [
Expanded(child: Text(status.description)),
if (status.image != null)
SizedBox(
height: 50,
width: 50,
child: Image.network(status.image!),
),
],
),
);
}

String _getTimeString(DateTime date) {
int difference = DateTime.now().difference(date).inHours;
if (difference == 0) {
return "few minutes ago";
}
if (difference < 24) {
return DateFormat('h:mm a').format(date);
}
return DateFormat('d-MM-yyyy').format(date);
}
}
120 changes: 120 additions & 0 deletions lib/src/widgets/services_updates_widget.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
import 'package:cake_wallet/di.dart';
import 'package:cake_wallet/entities/preferences_key.dart';
import 'package:cake_wallet/entities/service_status.dart';
import 'package:cake_wallet/src/widgets/primary_button.dart';
import 'package:cake_wallet/src/widgets/service_status_tile.dart';
import 'package:cake_wallet/themes/extensions/dashboard_page_theme.dart';
import 'package:cake_wallet/themes/extensions/wallet_list_theme.dart';
import 'package:flutter/material.dart';
import 'package:shared_preferences/shared_preferences.dart';
import 'package:url_launcher/url_launcher.dart';

class ServicesUpdatesWidget extends StatelessWidget {
final Future<ServicesResponse> servicesResponse;

const ServicesUpdatesWidget(this.servicesResponse, {super.key});

@override
Widget build(BuildContext context) {
return Padding(
padding: const EdgeInsets.all(8.0),
child: FutureBuilder<ServicesResponse>(
future: servicesResponse,
builder: (context, state) {
return InkWell(
onTap: state.hasData
? () {
// save currentSha when the user see the status
getIt
.get<SharedPreferences>()
.setString(PreferencesKey.serviceStatusShaKey, state.data!.currentSha);

showModalBottomSheet(
context: context,
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.only(
topLeft: Radius.circular(50),
topRight: Radius.circular(50),
),
),
constraints: BoxConstraints(
maxHeight: MediaQuery.of(context).size.height / 2,
minHeight: MediaQuery.of(context).size.height / 4,
),
builder: (context) {
Widget body;
if (state.data!.servicesStatus.isEmpty) {
body = Center(
child: Text("Everything is up and running as expected"),
);
} else {
body = SingleChildScrollView(
child: Column(
children: state.data!.servicesStatus
.map((status) => ServiceStatusTile(status))
.toList()),
);
}
return Padding(
padding: const EdgeInsets.symmetric(horizontal: 12, vertical: 20),
child: Stack(
children: [
body,
Align(
alignment: Alignment.bottomCenter,
child: Padding(
padding: EdgeInsets.symmetric(
horizontal: MediaQuery.of(context).size.width / 8),
child: PrimaryImageButton(
onPressed: () {
try {
launchUrl(Uri.parse("https://status.cakewallet.com/"));
} catch (_) {}
},
image: Image.asset(
"assets/images/status_website_image.png",
color: Theme.of(context).brightness == Brightness.light
? Colors.white
: null,
),
text: "Status Website",
color: Theme.of(context)
.extension<WalletListTheme>()!
.createNewWalletButtonBackgroundColor,
textColor: Theme.of(context)
.extension<WalletListTheme>()!
.restoreWalletButtonTextColor,
),
),
)
],
),
);
},
);
}
: null,
child: Stack(
children: [
Image.asset(
"assets/images/notification_icon.png",
color: Theme.of(context).extension<DashboardPageTheme>()!.pageTitleTextColor,
),
if (state.hasData && state.data!.hasUpdates)
Container(
height: 7,
width: 7,
margin: EdgeInsetsDirectional.only(start: 8),
decoration: BoxDecoration(
color: Colors.red,
shape: BoxShape.circle,
),
),
],
),
);
},
),
);
}
}
Loading

0 comments on commit 6414364

Please sign in to comment.