Repository navigation
GH207: Keep Spectre exception UX and honor CakeException.ExitCode - #217
Merged
Merged
Conversation
devlead
commented
Oct 1, 2026
devlead
commented
Member
- Compute the exit code locally instead of calling ExceptionLogger.LogException so Cake.Sdk does not print a second Error line.
- Cache CLI/config verbosity in PostBuild and, below Diagnostic, print a Spectre Markup Error line; keep WriteException at Diagnostic.
- Do not resolve ICakeLog or ServiceProvider from the handler so _providerLock cannot deadlock.
- Refresh RegisterExceptionHandlers and PostBuildServiceProvider snapshots.
- fixes Return CakeException.ExitCode from generated host #207
…ExitCode - Compute the exit code locally instead of calling ExceptionLogger.LogException so Cake.Sdk does not print a second Error line. - Cache CLI/config verbosity in PostBuild and, below Diagnostic, print a Spectre Markup Error line; keep WriteException at Diagnostic. - Do not resolve ICakeLog or ServiceProvider from the handler so _providerLock cannot deadlock. - Refresh RegisterExceptionHandlers and PostBuildServiceProvider snapshots. - fixes cake-build#207
devlead
enabled auto-merge
October 1, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.