-
-
Notifications
You must be signed in to change notification settings - Fork 764
[WIP] Improve assembly loading and performance #4477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[WIP] Improve assembly loading and performance #4477
Conversation
|
To provide some context here, how many tools/addins are being restored for these timings? Have you got significantly more tools compared to addins? |
|
Also.... what are the timing differences with this change implemented? Is there a significant difference with this change in place? |
About ~ 8 tools, but these are large (800mb) because of full .net fx inclusion on some tools, which could cause it to be a bit more slow during extraction. Also seem to get hit by a but where restoring packages does not seem to work with the latest alpha. Investigating the issue and will create a new PR for that as well. |
No improvements yet, trying to figure out where the biggest wins are. |
|
For reference about the other issue I found: #4478 |
|
Added #4500, will now continue working on this optimization. |
|
Caching in the %temp% is now working (when using pinned versions), shaving off approx 30 seconds per build. Now going to see if we can optimize a bit more. |
For some background info, see https://github.com/orgs/cake-build/discussions/4476
This adds timings and makes sure the correct version of addins are loaded.
Here are some added timings that could be used to find where cake is taking time to initialize:
This is on a fast machine, so installing the tools is the hardest part. A very easy win is to set a shared tools path for the build scripts so it doesn't have to re-install all the tools on each build.
Pinging @gep13 since he was part of the original discussion, but no need for anything just yet.