Update terraform CI to execute in its own job #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also open to deleting the terraform-docs functionality, I haven't found it that useful. But if you figured it out, then that's great too! |
|
I guess I would leave that up to you all! It should work either way...I did test the scenarios where files do get changed. |
britt-allen
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
This ended up being more painful than the related task in Caltrans' repo due to the terraform-docs automation. The terraform-docs action works for our use case, though it requires 1 invocation per file and also has a bug (see use of $OUTPUT_FILE here) that means it only fully works on 1 of our 3 files.