Skip to content

Set connectionFailed to Print error log by default. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set connectionFailed to Print error log by default. #18

wants to merge 1 commit into from

Conversation

DHosseiny
Copy link
Collaborator

Desirable behavior is to see error log when something unexpectedly happened.

@DHosseiny DHosseiny requested a review from PHELAT January 29, 2020 13:17
@PHELAT
Copy link
Contributor

PHELAT commented Jan 31, 2020

Thank you for your contribution on this project.
It would be much nicer if user could turn off this default behavior using a flag, perhaps inside PaymentConfiguration class you could add a flag for this purpose. Also, it's much preferred to have this behavior throughout the library and not just for connectionFailed callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHELAT PHELAT Awaiting requested review from PHELAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DHosseiny @PHELAT