refactor: Require ActiveClusterName for active-active domains #7304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
approved these changes
Oct 7, 2025
c-warren
requested review from
3vilhamster,
Groxx,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Shaddoll
approved these changes
Oct 7, 2025
… domains to get the correct failover version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Requires ActiveClusterName to be set for active-active domains
Why?
Active-Active domains will use the ActiveClusterName as the "default" ActiveCluster for any workflows that do not specify a valid
scope:nameClusterAttribute. This makes migration simple (existing domains can just start adding ClusterAttributes to divide work).How did you test it?
Unit tests + simulations.
Canary to come.
Potential risks
The existing Canary or Simulation tests may start to fail. I plan on validating that they do not prior to merging.
Release notes
Active-Active domains now require an ActiveClusterName.
Documentation Changes
N/A