-
Notifications
You must be signed in to change notification settings - Fork 859
feat(Shard Distributor): In-memory cache for shard to executor, and remove shard to executor mapping in ETCD #7289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakobht
merged 19 commits into
cadence-workflow:master
from
jakobht:shardDistributorMemoryChacheRemoveShardToExecutorMapping
Oct 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ce0465
to
8d61eb7
Compare
eleonoradgr
reviewed
Oct 2, 2025
service/sharddistributor/store/etcd/executorstore/shardcache/namespaceshardcache.go
Show resolved
Hide resolved
eleonoradgr
reviewed
Oct 2, 2025
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
…th application logic Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
… it's own package Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
22cfc2b
to
bc389d0
Compare
eleonoradgr
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed together offline
jakobht
commented
Oct 9, 2025
service/sharddistributor/store/etcd/executorstore/shardcache/namespaceshardcache.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now have an in-memory cache for each of the name spaces on each shard distributor instance. The cache will be updated when things change in the database, using ETCD watches.
Also separated the ETCD store into more modules.
Why?
Before we attempted to push all the shard-to-executor mappings directly to the ETCD in a single transaction, this didn't work due to the number of transactions being way too big for ETCD.
How did you test it?
Unit tests and local runs
Potential risks
Currently the subscriptions to the database produces too many events, will address this in the next PR
Release notes
Documentation Changes