feat: Add Microsoft Phi-3 to Cactus #240
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-raised with custom tokenizer and chat-template support after repo mishaps over the past few days.
This PR adds support for Microsoft’s Phi-3 model ++ improves the robustness of the test suite for models that do not support embeddings.
Phi-3-Mini-4K-Instructis a 3.8B parameter model and comes in 4K and 128K context-length variants. Turns out FP16 works well for Phi-3, but performance degrades sharply with INT8; results are shared below.convert_hf.pyto handle these weight configurations during conversion.Testing Environment (For Repro):
Results
Phi-3-mini-4k-instruct (INT8)
Phi-3-mini-4k-instruct (FP16)
cc: @HenryNdubuaku