Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #375. add alerts to candidate and referendum layouts and pages. #377

Merged
merged 3 commits into from
Jun 6, 2020

Conversation

lukehtravis
Copy link
Contributor

This work resolves #375

Created two new layouts, one for the text in each alert, and then added them to the various parts of the different layouts in candidate.html and referendum.html

Previews

Large screens

referendum alert
candidate alert

Small screens
mobile alerts section

@lukehtravis lukehtravis requested review from tdooner and anlawyer May 31, 2020 18:49
@lukehtravis lukehtravis self-assigned this May 31, 2020
Copy link
Member

@anlawyer anlawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for working on it!

Before merging, I think it'd be nice for these two new includes to actually be combined into one file, since they're nearly identical. You can pass in some variable to the one includes to determine whether it should say "candidate" or "ballot measure" based on the layout it's being rendered in (since that's the only difference between the two files). If we want to further change the messaging depending on the type of race, we can split these into two files later on, but for now we can keep it simple with just the one.

@lukehtravis lukehtravis requested a review from anlawyer June 5, 2020 18:17
@lukehtravis
Copy link
Contributor Author

@anlawyer good idea. went in and harmonized those files. It's just one at this point, and functionality has been tested and works the same as before.

Copy link
Member

@anlawyer anlawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@anlawyer anlawyer merged commit f255ab0 into master Jun 6, 2020
@anlawyer anlawyer deleted the issue-375-add-alerts-links branch June 6, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to Alerts on candidate and referendum pages
2 participants