Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Alerts on candidate and referendum pages #375

Closed
tdooner opened this issue May 30, 2020 · 1 comment · Fixed by #377
Closed

Add link to Alerts on candidate and referendum pages #375

tdooner opened this issue May 30, 2020 · 1 comment · Fixed by #377
Assignees
@lukehtravis

Comments

@tdooner
Copy link
Member

tdooner commented May 30, 2020

Candidate pages should say:

Want to stay informed about this candidate? Sign up for Open Disclosure Alerts to get a daily email of election updates in your inbox.

Referendum pages should say:

Want to stay informed about this ballot measure? Sign up for Open Disclosure Alerts to get a daily email of election updates in your inbox.

I propose we put them underneath the contributions/expenditures graphs. Also, I think it will feel most natural if the links are set to target="_blank" so they open in a new tab.
lukehtravis added a commit that referenced this issue May 31, 2020
@lukehtravis
issue #375. add alerts to candidate and referendum layouts and pages.
e6a7f8f
@lukehtravis lukehtravis mentioned this issue May 31, 2020
Merged
@lukehtravis lukehtravis self-assigned this May 31, 2020
@lukehtravis
Copy link
Contributor

Put up the following PR request implementing this fix
#377

anlawyer added a commit that referenced this issue Jun 6, 2020
@anlawyer
Merge pull request #377 from caciviclab/issue-375-add-alerts-links
f255ab0 
issue #375. add alerts to candidate and referendum layouts and pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehtravis lukehtravis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue #375. add alerts to candidate and referendum layouts and pages. caciviclab/odca-jekyll
2 participants
@tdooner @lukehtravis