feat(build): replace runc with libcontainer API #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the runc CLI dependency with direct libcontainer API usage from youki. This eliminates the need for external dependency and process spawning, while using a faster container runtime. Key changes: - Remove runc and youki CLI dependencies from shell.nix - Add libcontainer as a Rust dependency (from youki tagpr-from-v0.5.3 branch) - Rewrite OCIBuildService to use ContainerBuilder API directly - Implement proper container state management using refresh_status() - Add container and bundle cleanup after execution - Improve error handling with container state validation The implementation now programmatically creates and manages containers using libcontainer's API, providing better resource management and error handling compared to spawning external CLI processes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Change-Id: Ie7714b6c129e54bf8c29accf4c72ba889b656c36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the runc CLI dependency with direct libcontainer API usage from youki. This eliminates the need for external dependency and process spawning, while using a faster container runtime.
Key changes:
The implementation now programmatically creates and manages containers using libcontainer's API, providing better resource management and error handling compared to spawning external CLI processes.
🤖 Generated with Claude Code
Change-Id: Ie7714b6c129e54bf8c29accf4c72ba889b656c36