Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku compatible deploy #344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Heroku compatible deploy #344

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2019

Modify the Dockerfile & Nginx config a bit, so now it works both locally and on Heroku out of the box

@ghost ghost self-requested a review June 20, 2019 15:29
@@ -228,6 +229,7 @@ start_system() {
seed_db
echo "Starting Cachet! ..."
php artisan config:cache
envsubst '\$PORT' < /etc/nginx/conf.d/default.conf.template > /etc/nginx/conf.d/default.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may need to actually happen along with all of the sed replacement such as https://github.com/CachetHQ/Docker/blob/master/entrypoint.sh#L186 -- the CI failures seem to be related to a permissions error when trying to write to /etc/nginx/conf.d/default.conf as the non-root user.

Base automatically changed from master to main January 15, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant