fix: downgrade to edition 2021 and MSRV 1.80 for stable Rust compatibility #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
27Bslash6
force-pushed
the
fix/msrv-1.80
branch
from
63dee2f to
a9ad5c1
Compare
…ility Edition 2024 requires Rust 1.85+ which breaks installation for users on stable toolchains (e.g., Rust 1.84). MSRV 1.82 matches cachekit-core dependency requirements. Changes: - rust/Cargo.toml: edition 2024 → 2021, rust-version 1.91 → 1.82 Fixes #30
27Bslash6
force-pushed
the
fix/msrv-1.80
branch
from
a9ad5c1 to
4db471b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Edition 2024 requires Rust 1.85+ (stabilized February 2025), which breaks installation for users on older stable toolchains. A user reported this on Windows with Rust 1.84:
Since cachekit supports Python 3.9+ targeting enterprise environments with slower update cycles, a conservative Rust MSRV (1.80, released July 2024) aligns with that philosophy.
Changes
rust/Cargo.tomledition: 2024→2021,rust-version: 1.91→1.80Test plan
maturin buildpassesmake quick-checkpassesFixes #30