chore: use simple vX.Y.Z tags for releases #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set include-component-in-tag: false since this is a single-package repo. Fixes release-please looking for cachekit-v0.1.0 when actual tag is v0.1.0.
27Bslash6
force-pushed
the
fix/release-please-tags
branch
from
ed9f2fd to
99eab19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Release-please PR #15 is trying to release 0.2.0 with 0.1.0 commits because it can't find the
cachekit-v0.1.0tag.Actual tag:
v0.1.0Expected by release-please:
cachekit-v0.1.0Solution
Set
include-component-in-tag: falsesince this is a single-package repo. SimplevX.Y.Ztags are cleaner.After merge
v0.1.0)