ci: use manylinux_2_28 for aarch64 cross-compilation #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manylinux2014 has old GCC that doesn't define __ARM_ARCH for aarch64, breaking the ring crate build. manylinux_2_28 (AlmaLinux 8) has modern GCC 8+ toolchain. Requires glibc 2.28+ which is fine for Python 3.9+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ringcrate aarch64 cross-compilation failure by using manylinux_2_28 instead of manylinux2014.Problem
manylinux2014 uses old GCC that doesn't define
__ARM_ARCHfor aarch64 assembler, causing:Solution
Use manylinux_2_28 (AlmaLinux 8) which has GCC 8+ with proper aarch64 support.
Compatibility: Requires glibc 2.28+ (RHEL 8+, Ubuntu 18.04+, Debian 10+) - fine for Python 3.9+.
Test plan