Bump Go and docker/docker #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniponsg
force-pushed
the
dpons/bump
branch
4 times, most recently
from
c134884
to
991fb09
Compare
scheca
reviewed
Jul 30, 2024
| @@ -31,7 +32,7 @@ type RepositoryConfig struct { | |||
|
|
|||
| // Auth provides the default docker library's field to authenticate and will be used for pulling. | |||
| // Usually Username & Password fields should be filled. | |||
| Auth types.AuthConfig | |||
| Auth registry.AuthConfig | |||
There was a problem hiding this comment.
Hey! nice to see activity in this project 🔝
Would this be a breaking change? It's an exported field of an exported struct and its type has changed from types.AuthConfig to registry.AuthConfig
There was a problem hiding this comment.
Hey @scheca! Glad to see you here :)
Yes, it could be a breaking change. Bumping is being done due to vulnerabilities.
There was a problem hiding this comment.
Good point to note, thanks @scheca The types.AuthConfig type was defined as type AuthConfig = registry.AuthConfig in the previous version, so it doesn't look critical
daniponsg
force-pushed
the
dpons/bump
branch
3 times, most recently
from
e77c0c2
to
7be8998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/docker v24 is affected by CVE-2024-41110