Remove duplication in test function name #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ExUnit.Case.register_test/4` joins the test name with the name of the describe block to build a unique name and returns it as an atom. Since we use `scenario.name` already in the describe block, and we create only one test, we can give it a generic name. This reduces the likelyhood to reach the [erlang system limit] of 255 characters in an atom. [erlang system limit]: https://erlang.org/documentation/doc-5.8.4/doc/efficiency_guide/advanced.html#:~:text=Characters%20in%20an%20atom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExUnit.Case.register_test/4joins the test name with the name of the describe block to build a unique name and returns it as an atom. Since we usescenario.namealready in the describe block, and we create only one test, we can give it a generic name.This reduces the likelyhood to reach the erlang system limit of 255 characters in an atom.