Do not rely on Python2 to install Cloud9 dependencies #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredcoliveira
suggested changes
Oct 11, 2022
install.sh
Outdated
| echo "Python version 2.7 is required to install pty.js. Please install python 2.7 and try again. You can find more information on how to install Python in the docs: https://docs.aws.amazon.com/cloud9/latest/user-guide/ssh-settings.html#ssh-settings-requirements" | ||
| if ! type -P "$PYTHON" &> /dev/null; then | ||
| echo "Python version is required to install pty.js. Please install python and try again. You can find more information on how to install Python in the docs: https://docs.c9.io/ssh_workspaces.html" |
There was a problem hiding this comment.
version reads a bit awkward here (2nd word). Can we remove it? Also, I think we should keep the original url.
Suggested change
| echo "Python version is required to install pty.js. Please install python and try again. You can find more information on how to install Python in the docs: https://docs.c9.io/ssh_workspaces.html" | |
| echo "Python is required to install pty.js. Please install python and try again. You can find more information on how to install Python in the docs: https://docs.aws.amazon.com/cloud9/latest/user-guide/ssh-settings.html#ssh-settings-requirements" |
| @@ -36,8 +38,7 @@ if [ ! -d "$C9_DIR" ]; then | |||
| fi | |||
|
|
|||
| VERSION=1 | |||
| NODE_VERSION=v6.3.1 | |||
| NODE_VERSION_ARM_PI=v0.10.28 | |||
| NODE_VERSION=v12.16.1 | |||
There was a problem hiding this comment.
Node 16 has known security issues—see https://nodejs.org/en/blog/release/v12.20.1/. Can we instead add 12.20.1 to our CDN and use that here?
Suggested change
| NODE_VERSION=v12.16.1 | |
| NODE_VERSION=v12.20.1 |
There was a problem hiding this comment.
Hmm 12.20.1 has security issues too. Maybe it would be better to use 12.22.x. 12.22.9 is the version we current install at runtime.
Suggested change
| NODE_VERSION=v12.16.1 | |
| NODE_VERSION=v12.22.9 |
andredcoliveira
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.