-
Notifications
You must be signed in to change notification settings - Fork 61
Update dependencies; Fixed build instructions in README.md #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f736ac5
to
a9f5361
Compare
The "redirects" in astro.config.mjs make it difficult for others to contribute to c3-web. Also, I don't like how certain files/folders are hidden in the .vscode/settings.json, which is why I removed that file. Please check to see if the new CI script works. |
Could you not just do |
Redirects are a fact of life on the internet. We need to support older links but we also want to update our links to new structures when we update things |
The astro docs give the option of installing with pnpm or yarn, because those package managers offer signficant improvements over npm. I think npm should be deprecated.
Forking c3-web and running the CI script doesn't work without modifying the links. I think supporting older links is possible too, but that's a separate issue unless I'm mistaken. |
Some frameworks handle this problem by supporting different versions of the docs you can go back to. For example, the pnpm docs support changing the version: https://pnpm.io/next/motivation. |
So really I think that the redirects were done to simplify/shorten the URLs: https://web.archive.org/web/20240805175104/https://c3-lang.org/guide/my-first-project/ I don't think link rot matters too much when people can clone the entire repo and install the docs for offline use. Also, the lead developer of c3 has a "move fast and break things" approach. I think we should apply this principle to the docs as well. |
It might not matter to you but when that link is used externally and is someone's first interaction with c3 that's very different, they might think the project is dead |
Could you explain what you mean sorry? |
This adds N different deployments to think about. |
I think we need to remove pnpm for now, and improve the readme along the lines you suggested and call it a day. If we need to tweak the dependencies to fix the build then that needs to get updated also. |
What's the status for this one? |
Fixes c3lang/c3c#2331 and #156.