Fix for Issue #268: Windows-specific failure due to file locking#277
Open
moritz-baumgart wants to merge 1 commit intoc0fec0de:mainfrom
Open
Fix for Issue #268: Windows-specific failure due to file locking#277moritz-baumgart wants to merge 1 commit intoc0fec0de:mainfrom
moritz-baumgart wants to merge 1 commit intoc0fec0de:mainfrom
Conversation
moritz-baumgart
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #268, which occurs on Windows systems due to how Windows handles file locking. Specifically, the issue arises because Windows locks the dotfile while it is still open, causing the related test case to fail.
The test in question (test_dotexport.py, lines 56–69) passes successfully under WSL (and likely other UNIX-like envorinments, but I did not test that right now), but fails on native Windows setups.
I've implemented the fix suggested by @jhaerig in the issue thread, which resolves the failure on my Windows machine.