-
-
Notifications
You must be signed in to change notification settings - Fork 86
Changed the design of the page #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Made minimal gradients to give friendly and minimal feeling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whizzbbig Glitches up when it comes to responsiveness
Done 👍🏻 |
@whizzbbig Those bubbles still don't work perfectly and the screen glitches off on different sizes. Make sure it's responsive for all sizes. |
The only glitch i've found is this one which not related to those bubbles can't help there Screen.Recording.2565-10-19.at.3.30.33.PM.movand also it might be very impulse if you see it from chrome dev tools it |
@whizzbbig Do check again. Noteslify is not having the issue in it's code. Thee website homepage is completely responsive. The bubbles are creating issues. Check noteslify.stonecss.com ( Production ) or even the latest code from the repository. 2022-10-19.15-54-02.mp4 |
I've made them more subtle according to dimensions of other devices but what i can see here isn't from the bubbles this video is from the offical site of noteslify Screen.Recording.2565-10-19.at.4.21.23.PM.mov |
Checked again. I used different devices from Browserstack as well. The issue is from your end. I tried the size you mentioned above. Works perfectly fine on different devices. |
@devarshishimpi now check |
It is not because of bubbles it was footer all the way if you've checked proper you would have noticed that
@devarshishimpi it was footer overflowing all the time its been fixed now 😆 |
see this Screen.Recording.2565-10-19.at.3.30.33.PM.mov |
Yes I saw that. There's no issue on my end with it tho. And neither on other devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me now. I'll make a PR in your fork shortly containing the same images but with transparent background. Once that's done. I'll merge this PR.
Hey the issue is still on the offical site now ( you'll see it is fine but its not the time you'll change the content of footer it will presist for sure right now those links section has been set to soon ) and i've fixed it you can check now it was all time footer that doing the thing |
Yeaahhhh! now its the one issue that is left to fix is making that navigation awesome |
@devarshishimpi hey can you merge this PR as its not accepted for Hactoberfest for which it is really meant so please help me with that |
Don't worry. It will be merged before hacktoberfest and the moment the images are updated in your fork. I'll create a PR shortly for the same. |
Just give me a time of one day. I'll raise a PR in your fork at the earliest. And then merge this. |
i can help you out with the images too |
if you are ready for that then merge this PR ill create new issue and PR right away |
Okay |
Describe your changes
Made minimal gradients to give friendly and minimal feeling
Screenshots - If Any (Optional)
https://user-images.githubusercontent.com/54703305/196609711-a72480e7-3bcf-4e6f-bdf6-a4dcf630aa49.mov

Issue ticket number and link - If Any
#162
Checklist before requesting a review
I have performed a self-review of my code.
Followed the repository's Contributing Guidelines.
I ran the app and tested it locally to verify that it works as expected.
I have starred the repository.
Additional Information (Optional)