Skip to content

Add default Info #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add default Info #652

wants to merge 2 commits into from

Conversation

HGuillemet
Copy link
Contributor

See #649 (comment)

This lines and this lines are not useful anymore with this PR. But you may want to keep them for compatibility.

@HGuillemet
Copy link
Contributor Author

Do not merge this for the moment. There is an obscure side effect here:
when enumerate is true per default on an Info where pointerTypes has been set, valueType here is set to true and we iterate over the (single) valueTypes instead of the pointerTypes.

@saudet
Copy link
Member

saudet commented Feb 17, 2023

Right, Info.enumerate() shouldn't be set for "normal" types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HGuillemet @saudet