Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modesecurity] Upgrade modesecurity to be able to use it at Debian12 that does not contain libpcre++-dev lib anymore #1490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaandy
Copy link

@yaandy yaandy commented Apr 8, 2024

No description provided.

@@ -23,15 +23,16 @@ fi

case $PLATFORM in
linux-x86_64)
yum install -y pcre2-devel
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed - in forked repo changes to .github/actions/deploy-centos/action.yml does not take any affect somewhy and original code was executed in the job

@saudet
Copy link
Member

saudet commented Apr 8, 2024 via email

@yaandy yaandy force-pushed the modsecurity_3_0_12_for_debian12 branch 2 times, most recently from 6592542 to 815087f Compare April 9, 2024 08:29
@yaandy
Copy link
Author

yaandy commented Apr 9, 2024

image image ![image](https://github.com/bytedeco/javacpp-presets/assets/15327801/76e45b9d-a7b2-438f-afc1-b2b07715be7e) ![image](https://github.com/bytedeco/javacpp-presets/assets/15327801/f4d0232b-5d87-49ae-8b34-21898e14e8f6)

As I understand it runs on Centos, but looks like the action definition is not from a forked branch with changes.
I even try to add it to ubuntu
image

but looks like it is not used for modsecurity module.

@saudet Could you please suggest how to get a snapshot artifacts ? can't understand where they should be posted after the build in a branch

@yaandy yaandy force-pushed the modsecurity_3_0_12_for_debian12 branch 3 times, most recently from cc5a2bd to eea2614 Compare April 10, 2024 12:23
…that does not contain libpcre++-dev lib anymore
@yaandy yaandy force-pushed the modsecurity_3_0_12_for_debian12 branch from eea2614 to afb20ce Compare April 10, 2024 13:41
@saudet
Copy link
Member

saudet commented Apr 14, 2024

As I understand it runs on Centos, but looks like the action definition is not from a forked branch with changes. I even try to add it to ubuntu image

but looks like it is not used for modsecurity module.

Right, so I'm asking you to ignore the centos action and update the workflow to use the ubuntu one instead

@saudet Could you please suggest how to get a snapshot artifacts ? can't understand where they should be posted after the build in a branch

If you have an account for Sonatype OSSRH, you can set those secrets in your own fork:
https://github.com/bytedeco/javacpp-presets/blob/master/.github/workflows/modsecurity.yml#L15-L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants