[C#] Add cancel support for futures and streams#1580
Open
yowl wants to merge 1 commit intobytecodealliance:mainfrom
Open
[C#] Add cancel support for futures and streams#1580yowl wants to merge 1 commit intobytecodealliance:mainfrom
yowl wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Clear up some debug use same package location for codegen and runtime tests.
yowl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some support for canceling futures and streams..While dotnet
Taskare cancelable via tokens, that is not the design we want for components, so in this PR there is introduced aComponentTaskwhich is a merging of aTaskand aTaskCompletionSource(and their generic counterparts) which adds aCancelmethod.In place of Rust's
Result<>this uses aComponentTaskResulttogether with aCancelCodeenum.LiftingTaskCompletionSourceis a placeholder for returning values from async functions. It requires the lifting code, but hopefully can be used as a starting point.Changes all task continuations to be
ExecuteSynchronouslyas we only have one thread, and this is more predicable. This should be removed if we get true multithreading.The
indexsuffix on imports is now created sequentially, no longer hard coded to0.Adds the runtime test,
future-cancel-read