[gc_fuzz]: Add new GC ops to the fuzzer setup - #14196
Open
khagankhan wants to merge 2 commits into
Open
Conversation
khagankhan
changed the title
khagankhan
changed the title
github-actions
Bot
added
the
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
reviewed
Aug 24, 2026
Comment on lines
-485
to
+512
| for i in 0..concrete_count { | ||
| let concrete = struct_type_base + i; | ||
| local_decls.push(( | ||
| 1, | ||
| ValType::Ref(RefType { | ||
| nullable: true, | ||
| heap_type: wasm_encoder::HeapType::Concrete(concrete), | ||
| }), | ||
| )); | ||
| let typed_local2_base: u32 = typed_local_base + concrete_count; | ||
| for _ in 0..2 { | ||
| for i in 0..concrete_count { | ||
| let concrete = struct_type_base + i; | ||
| local_decls.push(( | ||
| 1, | ||
| ValType::Ref(RefType { | ||
| nullable: true, | ||
| heap_type: wasm_encoder::HeapType::Concrete(concrete), | ||
| }), | ||
| )); | ||
| } |
Member
There was a problem hiding this comment.
I don't understand the purpose of this change?
Contributor
Author
There was a problem hiding this comment.
This second bank of locals is for array.copy. Because both operands can be the same concrete array type and array.copy traps on Null it needs two locals for src and dst when checking. I
P.S. It also does it for struct locals too but I did not want to "separate" arrays from structs atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new GC ops to the existing setup.
array.copyarray.new_elemarray.new_fixed+cc @fitzgen