Skip to content

Add explicit hint for generic call#13715

Merged
pchickey merged 2 commits into
bytecodealliance:mainfrom
Mark-Simulacrum:hint-generics
Jun 23, 2026
Merged

Add explicit hint for generic call#13715
pchickey merged 2 commits into
bytecodealliance:mainfrom
Mark-Simulacrum:hint-generics

Conversation

@Mark-Simulacrum

Copy link
Copy Markdown
Contributor

This fixes compilation with the new trait solver (probably an upstream
bug, haven't checked, but this is a trivial workaround). See compilation
failure here: rust-lang/rust#157590 (comment).

This hinting is already present for other calls to the same function (search for add_to_linker_instance:: in the edited file).

If possible, it would be great to get this released in a patch release of v46.

This fixes compilation with the new trait solver (probably an upstream
bug, haven't checked, but this is a trivial workaround). See compilation
failure here: rust-lang/rust#157590 (comment)
@Mark-Simulacrum Mark-Simulacrum requested a review from a team as a code owner June 23, 2026 00:51
@Mark-Simulacrum Mark-Simulacrum requested review from dicej and removed request for a team June 23, 2026 00:51
@tschneidereit tschneidereit requested review from a team and removed request for dicej June 23, 2026 12:27
@tschneidereit

Copy link
Copy Markdown
Member

Makes sense to me, but I'll wait for someone with more experience with this code to sign off.

@Mark-Simulacrum we can definitely do a patch release for this, yeah. How urgently do you need that? @alexcrichton is on PTO this week, but if it's urgent I'll reach out to other maintainers

@pchickey

pchickey commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum can you please make a PR cherry-picking the squashed commit of this onto the release-46.0.0 branch? I will get it out in a patch release tomorrow.

@pchickey pchickey added this pull request to the merge queue Jun 23, 2026
Merged via the queue into bytecodealliance:main with commit 6ba6a62 Jun 23, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants