Move exception lock to ModuleInstance data.#4772
Open
vchigrin wants to merge 3 commits intobytecodealliance:mainfrom
Open
Move exception lock to ModuleInstance data.#4772vchigrin wants to merge 3 commits intobytecodealliance:mainfrom
vchigrin wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
lum1n0us
requested changes
Feb 3, 2026
Contributor
lum1n0us
left a comment
There was a problem hiding this comment.
-
The PR has affected the layout of
WASMModuleInstanceExtra, which will change keyoffsetofvalues in AOT files. Therefore, it requires a newAOT_CURRENT_VERSIONin core/config.h. -
Obviously, there is a failed CI that should be fixed.
eca416a to
3bc7eb7
Compare
Author
|
Thank you so much! Fixed both issues, all CI checks are green now. |
lum1n0us
reviewed
Mar 9, 2026
906cf84 to
93af779
Compare
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.
93af779 to
2e07a8c
Compare
2e07a8c to
bdd43c7
Compare
lum1n0us
approved these changes
Mar 12, 2026
Author
|
Thank you so much for review.
Of course, you, as code owner, know better all nuances. I just write to ensure that we'll not force our users re-compile all their AOT programs without need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.