Add missing condition for V128 in WASM_OP_TEE_LOCAL #4643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jammar1
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
loganek
approved these changes
Sep 22, 2025
lum1n0us
approved these changes
Sep 23, 2025
|
@jammar1 please refer to #4645 and add something in tests/regression/ba-issues/issues |
jammar1
force-pushed
the
jammar1/missing-v128-tee-local
branch
from
a5bdf35 to
ff71ad4
Compare
jammar1
commented
Sep 24, 2025
jammar1
force-pushed
the
jammar1/missing-v128-tee-local
branch
from
ff71ad4 to
5ba1b33
Compare
lum1n0us
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a crash with this error "Error: Exception: invalid local type" and it seems like WASM_OP_TEE_LOCAL was missing a branch for the V128 type.