Make benchmark_effect_size test less flaky
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It complains if there isn't any variance between samples, so bump up the number of iterations we perform to make getting all identical samples extremely unlikely.
|
Wait... how did you figure out that variance is the issue with this test? When I look at the test output, I don't see that, e.g., with this latest failure. I guessed that it was some weird file issue in #178 but if it's actually fixed by more runs, then great! But how? Shouldn't we be able to see something of this in the test output? |
|
I think the crate we use has some internal unwraps/panics rather than exposing results. But I did see at least one bit of log output for one of the failures (maybe before doing a retry?) that mentioned variance. |
abrown
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It complains if there isn't any variance between samples, so bump up the number
of iterations we perform to make getting all identical samples extremely
unlikely.
This flaky test seems to be holding back #194 and #193