-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated code generation logic to it's own crate #890
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the crate feature we talked about before so we can reduce visibility for the methods for working with the v2 and default plugins to the CLI crate?
Otherwise, I think it's a structurally sound change besides removing some methods from the public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a step to run tests for the codegen crate similar to the Test CLI step and a step to lint the codegen crate similar to the CLI crate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a target for testing the codegen crate and add it as a prerequisite for the tests
target?
Totally forgot, of course! |
Description of the change
Splits Code Generation logic out into it's own crate (from CLI).
Things I attempted to do pro-actively here,
javy-codegen
crate and thecli
crate.javy-codegen
.Things we might want to change/add,
Why am I making this change?
To enable runtime generation of WASM modules without shelling out to a CLI.
Checklist
javy-cli
andjavy-plugin
do not require updating CHANGELOG files.Related PR's
877, 879