Make event loop a runtime config instead of a Cargo feature #838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Changes
experimental_event_loop
from a Cargo feature to a runtime config. This also introduces ajavy_plugin_api::Config
that wraps thejavy::Config
so we can add configuration options that only affect thejavy_plugin_api
crate behaviour and that don't inherently change how thejavy::Runtime
behave (that's why I didn't add it tojavy::Config
). Since we change the type that needs to be passed forinitialize_runtime
, I've bumped thejavy-plugin-api
version by a major version. We have minimal users of the plugin API crate so the impact should be limited.Why am I making this change?
This should simplify the build and test infrastructure since we only need to build one artifact for the plugin and the CLI tests instead of two plugins. This should also help with cacheability of build artifacts. This will also make it easier to use the event loop functionality.
Checklist
javy-cli
andjavy-plugin
do not require updating CHANGELOG files.