Create plugin-api crate and move most of core's logic into it #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
approved these changes
Oct 31, 2024
crates/core/Cargo.toml
Outdated
| @@ -11,10 +11,9 @@ crate-type = ["cdylib"] | |||
|
|
|||
| [dependencies] | |||
| anyhow = { workspace = true } | |||
| javy = { workspace = true, features = ["export_alloc_fns", "json"] } | |||
| once_cell = { workspace = true } | |||
| javy-plugin-api = { workspace = true, features = ["json"] } | |||
There was a problem hiding this comment.
Is it intended to have this dependency at the workspace level? I think it's not shared across any other crates in the workspace, right?
There was a problem hiding this comment.
I can move it out of the workspace into javy-core. For some reason I thought the javy crate was only used by javy-core but I can see after looking that the fuzzer also uses it.
Co-authored-by: Saúl Cabrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a library crate named
javy-plugin-apiwith a lotjavy-core's logic. The idea is a Javy plugin developer should make their Javy plugin cdylib dependent on thisjavy-plugin-apicrate and it will handle most of the exports for them and let them configure their runtime.Why am I making this change?
Part of #768. We don't want every plugin developer to have to re-implement most of the existing logic in
javy-corethemselves so this provides a crate they can depend on so they don't have to re-implement the existing logic.I'm opting to leave the allocation function definitions in the
javylibrary crate for this PR. I'll move the functions in the next PR.Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.