Skip to content

Commit

Permalink
Clarify the usage of clippy::too_many_arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
saulecabrera committed Sep 6, 2024
1 parent acd943c commit e88ec95
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions crates/runner/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ use wasi_common::sync::WasiCtxBuilder;
use wasi_common::WasiCtx;
use wasmtime::{AsContextMut, Config, Engine, Instance, Linker, Module, OptLevel, Store};

// TODO: Some of the methods in the Runner could be refactored to take structs
// as parameters rather than individual parameters to avoid verbosity.
//
// This refactoring will be a bit challenging until we fully deprecate the
// `compile` command.

#[derive(Clone)]
pub enum JavyCommand {
Build,
Expand Down Expand Up @@ -258,6 +252,7 @@ impl StoreContext {
}

impl Runner {
#[allow(clippy::too_many_arguments)]
fn build(
bin: String,
root: PathBuf,
Expand Down Expand Up @@ -499,6 +494,13 @@ impl Runner {
file
}

// TODO: Some of the methods in the Runner (`build`, `build_args`) could be
// refactored to take structs as parameters rather than individual
// parameters to avoid verbosity.
//
// This refactoring will be a bit challenging until we fully deprecate the
// `compile` command.
#[allow(clippy::too_many_arguments)]
fn build_args(
input: &Path,
out: &Path,
Expand Down

0 comments on commit e88ec95

Please sign in to comment.