Feat: Add support for Yiciyuan device #688
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Requesting review from @blackspherefollower as they handle most of the device code. |
|
@weijunji Do you have product links for these devices? The only device from them I was aware of was their DG Labs powerbox clone, which won't be supported by buttplug.io. Scrolling through their Twitter, the only cups I see appear to be oscillating strokers, but I can't work out if that's one of their cups or not. |
blackspherefollower
suggested changes
Feb 20, 2025
| - identifier: | ||
| - YCY-FJB-02 | ||
| name: YiCiYuan Masturbation Cup 02 |
There was a problem hiding this comment.
Are we sure that the cups aren't oscillating devices?
| @@ -0,0 +1,43 @@ | |||
| // Buttplug Rust Source Code File - See https://buttplug.io for more info. | |||
| // | |||
| // Copyright 2016-2024 Nonpolynomial Labs LLC. All rights reserved. | |||
There was a problem hiding this comment.
The copyright should be 2016-2025
| @@ -409,6 +409,7 @@ async fn test_device_protocols_embedded_v2(test_file: &str) { | |||
| #[test_case("test_fleshy_thrust_protocol.yaml" ; "Fleshy Thrust Sync Protocol")] | |||
| #[test_case("test_nexus_revo.yaml" ; "Nexus Revo Protocol")] | |||
| #[test_case("test_omobo_protocol.yaml" ; "Omobo Protocol")] | |||
| #[test_case("test_yiciyuan_protocol.yaml" ; "Yiciyuan Protocol")] | |||
There was a problem hiding this comment.
Since the test only uses the vibrate command, it should be in all 4 test suites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for YiCiYuan(役次元) devices, I have tested it with YCY-FJB-02. And all devices are sharing the same protocol.
YiCiYuan is a sextoy manufacturer from China, their products include Masturbation Cup and Vibrator.
You can get info about these devices from website and X (https://x.com/chastitybeltsex).