Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Feature flag for GitHub Summary feature #288

Merged
merged 9 commits into from
Jul 11, 2020

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Jul 11, 2020

Part of #186

What does this do

  • add feature flag field to GitHub Summary; workspace admins can enable / disable
  • workspaces can enable or disable the creation of daily summaries

Why are we doing this

Multitenancy requires admins to control features.

How should this be tested

  • wrote a test for the job
  • manually tested toggle button in admin interface

Migrations

Added a field which requires a data migration

Dependencies

n/a

Callouts

  • need to fix login

@alysivji alysivji changed the title Active field Database feature flag for GitHub Summary feature Jul 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #288 into master will decrease coverage by 1.10%.
The diff coverage is 60.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   96.51%   95.40%   -1.11%     
==========================================
  Files          71       71              
  Lines        1981     2025      +44     
==========================================
+ Hits         1912     1932      +20     
- Misses         69       93      +24     
Impacted Files Coverage Δ
busy_beaver/apps/web/views.py 70.58% <20.00%> (-12.75%) ⬇️
busy_beaver/apps/github_integration/models.py 69.38% <48.27%> (-30.62%) ⬇️
busy_beaver/exceptions.py 84.21% <60.00%> (-4.37%) ⬇️
busy_beaver/app.py 97.77% <100.00%> (+3.77%) ⬆️
busy_beaver/apps/github_integration/cli.py 100.00% <100.00%> (+7.40%) ⬆️
...beaver/apps/github_integration/summary/workflow.py 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7eb1d6...beda4ea. Read the comment docs.

@alysivji alysivji changed the title Database feature flag for GitHub Summary feature Feature flag for GitHub Summary feature Jul 11, 2020
@alysivji alysivji merged commit 247d262 into busy-beaver-dev:master Jul 11, 2020
@alysivji alysivji deleted the active-field branch July 11, 2020 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants