Skip to content

Commit

Permalink
CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DavisVaughan committed Sep 20, 2019
1 parent f4eec91 commit 700fe92
Showing 1 changed file with 6 additions and 21 deletions.
27 changes: 6 additions & 21 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
## Resubmission

I accidentally shipped the entire revdep/ folder alongside the package. I have
added it to '.Rbuildignore' now.

## Release Summary

This is a minor release of 'tibbletime'. It fixes a few small bugs regarding
the new version of 'tibble', and changes a test in preparation for
'dplyr' 0.8.0.

I have also changed the maintainer email to reflect a job change.
This is a minor release of 'tibbletime'. It mainly updates the `tidyr::nest()`
and `tidyr::unnest()` methods for compatability with tidyr 1.0.0.

## Test environments
* local Mac install, R 3.5.1
* ubuntu 14.04.5 (on travis-ci) (3.4.4, devel, release)
* local Mac install, R 3.6.0
* ubuntu 14.04.5 (on travis-ci) (3.6.0, devel, release)
* win-builder (devel and release)

## R CMD check results
Expand All @@ -27,13 +19,6 @@ There were no ERRORs, WARNINGs or NOTEs.

## Revdep checks

The 3 reverse dependencies passed with no errors, and the warnings / notes
were unrelated to this update.

|package |version |error |warning |note |
|:----------------------------------|:-------|:-----|:-------|:----|
|[anomalize](problems.md#anomalize) |0.1.1 | | |1 |
|[tidyquant](problems.md#tidyquant) |0.5.5 | |1 | |
|tsbox |0.0.3 | | | |

The 4 revdeps have been checked, and nothing has been broken by this release.
This should free up anomalize to be fixed as well (tidyr 1.0.0 broke it).

0 comments on commit 700fe92

Please sign in to comment.