Fixes #91 - dplyr::ungroup() fix

business-science · Jun 18, 2020 · 3fe86c4 · 3fe86c4
1 parent a24b547
commit 3fe86c4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # tibbletime (development version)
 
+* [Fix Ungroup Issue](https://github.com/business-science/tibbletime/issues/91)
+
 # tibbletime 0.1.4
 
 * Minor release to stay compatible with tibble 3.0.0 and the upcoming release

diff --git a/R/compat-dplyr.R b/R/compat-dplyr.R
@@ -139,8 +139,13 @@ group_by.tbl_time <- function(.data, ...) {
 #'
 ungroup.tbl_time <- function(x, ...) {
   #reconstruct(NextMethod(), x)
-  copy_.data <- new_tbl_time(x, get_index_quo(x), get_index_time_zone(x))
-  reconstruct(NextMethod(), copy_.data)
+  # copy_.data <- new_tbl_time(x, get_index_quo(x), get_index_time_zone(x))
+  # ret <- reconstruct(NextMethod(), copy_.data)
+  idx_quo <- get_index_quo(x)
+  idx_tz  <- get_index_time_zone(x)
+  tbl     <- dplyr::ungroup(tibble::as_tibble(x))
+  new_tbl_time(tbl, idx_quo, idx_tz)
+
 }
 
 

diff --git a/tests/testthat/test_grouped_df.R b/tests/testthat/test_grouped_df.R
@@ -13,6 +13,8 @@ test_time <- tibble::tibble(
 test_grouped_tbl_time <- as_tbl_time(test_time, date) %>%
   group_by(group)
 
+
+
 # Tests
 
 test_that("Ungroup works", {