-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to specify an empty string option #98
Conversation
9d1df9b
to
0e01002
Compare
I will write a test for this implementation, but I don't know where to write it in |
c340524
to
0e01002
Compare
Thank you @massongit for bringing this issue to my attention. I will first confirm this and then open up an issue ticket. Please give me some time to look into this. |
OK, this was easy enough to confirm. I have opened up issue #99 to track this. I will start by coming up with appropriate tests, hopefully for both Windows and UNIX-type platforms. I don't have any tests for dictionaries besides ipadic, so I will need some time to come up with something that can cover Unidic, and perhaps Jumandic as well. |
@massongit, thank you for your patience. Here is what I have found:
This behavior of MeCab is consistent across ipadic, jumandic and unidic, and is not a function of the dictionary used. I expect that your Unidic
That means that unless you explicitly unset You are correct that Hence, I will be accepting your pull request. Thank you very much! I will come up with some unit tests to cover this new behavior. |
@buruzaemon Thank you for confirm and merging! |
(Related to taku910/mecab#41)
I enabled to specify an empty string option to enable to specify
node-format
option when using UniDic.