Merge branch 'feature/plugins' into bleeding

# Conflicts: # connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java # connector/src/main/java/org/geysermc/connector/network/translators/java/world/JavaChunkDataTranslator.java # connector/src/main/java/org/geysermc/connector/utils/ChunkUtils.java
bundabrg · Sep 9, 2020 · 73cd77b · 73cd77b
2 parents 3ce38ac + fab992e
commit 73cd77b
Show file tree

Hide file tree

Showing 33 changed files with 715 additions and 59 deletions.
diff --git a/.gitignore b/.gitignore
@@ -241,5 +241,5 @@ config.yml
 logs/
 public-key.pem
 locales/
-cache/
-plugins/
+/cache/
+/extensions/
diff --git a/bootstrap/bungeecord/pom.xml b/bootstrap/bungeecord/pom.xml
@@ -61,6 +61,10 @@
                                     <pattern>net.md_5.bungee.jni</pattern>
                                     <shadedPattern>org.geysermc.platform.bungeecord.shaded.jni</shadedPattern>
                                 </relocation>
+                                <relocation>
+                                    <pattern>com.fasterxml.jackson</pattern>
+                                    <shadedPattern>org.geysermc.platform.bungeecord.shaded.jackson</shadedPattern>
+                                </relocation>
                                 <relocation>
                                     <pattern>io.netty</pattern>
                                     <shadedPattern>org.geysermc.platform.bungeecord.shaded.netty</shadedPattern>
@@ -69,6 +73,22 @@
                                     <pattern>org.reflections</pattern>
                                     <shadedPattern>org.geysermc.platform.bungeecord.shaded.reflections</shadedPattern>
                                 </relocation>
+                                <relocation>
+                                    <pattern>com.google.common</pattern>
+                                    <shadedPattern>org.geysermc.platform.bungeecord.shaded.google.common</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>com.google.guava</pattern>
+                                    <shadedPattern>org.geysermc.platform.bungeecord.shaded.google.guava</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>org.dom4j</pattern>
+                                    <shadedPattern>org.geysermc.platform.bungeecord.shaded.dom4j</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>net.kyori.adventure</pattern>
+                                    <shadedPattern>org.geysermc.platform.bungeecord.shaded.adventure</shadedPattern>
+                                </relocation>
                             </relocations>
                         </configuration>
                     </execution>

diff --git a/bootstrap/bungeecord/src/main/resources/relocations.json b/bootstrap/bungeecord/src/main/resources/relocations.json
@@ -3,12 +3,32 @@
     "from": "net.md_5.bungee.jni",
     "to": "org.geysermc.platform.bungeecord.shaded.jni"
   },
+  {
+    "from": "com.fasterxml.jackson",
+    "to": "org.geysermc.platform.bungeecord.shaded.jackson"
+  },
   {
     "from": "io.netty",
     "to": "org.geysermc.platform.bungeecord.shaded.netty"
   },
+  {
+    "from": "com.google.common",
+    "to": "org.geysermc.platform.bungeecord.shaded.google.common"
+  },
+  {
+    "from": "com.google.guava",
+    "to": "org.geysermc.platform.bungeecord.shaded.guava"
+  },
   {
     "from": "org.reflections.reflections",
     "to": "org.geysermc.platform.bungeecord.shaded.reflections"
+  },
+  {
+    "from": "org.dom4j",
+    "to": "org.geysermc.platform.bungeecord.shaded.dom4j"
+  },
+  {
+    "from": "net.kyori.adventure",
+    "to": "org.geysermc.platform.bungeecord.shaded.adventure"
   }
 ]
diff --git a/bootstrap/spigot/pom.xml b/bootstrap/spigot/pom.xml
@@ -20,7 +20,7 @@
         <dependency>
             <groupId>org.spigotmc</groupId>
             <artifactId>spigot-api</artifactId>
-            <version>1.14-R0.1-SNAPSHOT</version>
+            <version>1.15.2-R0.1-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
@@ -79,6 +79,22 @@
                                     <pattern>org.reflections</pattern>
                                     <shadedPattern>org.geysermc.platform.spigot.shaded.reflections</shadedPattern>
                                 </relocation>
+                                <relocation>
+                                    <pattern>com.google.common</pattern>
+                                    <shadedPattern>org.geysermc.platform.spigot.shaded.google.common</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>com.google.guava</pattern>
+                                    <shadedPattern>org.geysermc.platform.spigot.shaded.google.guava</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>org.dom4j</pattern>
+                                    <shadedPattern>org.geysermc.platform.spigot.shaded.dom4j</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>net.kyori.adventure</pattern>
+                                    <shadedPattern>org.geysermc.platform.spigot.shaded.adventure</shadedPattern>
+                                </relocation>
                             </relocations>
                         </configuration>
                     </execution>

diff --git a/bootstrap/spigot/src/main/java/org/geysermc/platform/spigot/GeyserSpigotPlugin.java b/bootstrap/spigot/src/main/java/org/geysermc/platform/spigot/GeyserSpigotPlugin.java
@@ -57,7 +57,6 @@ public class GeyserSpigotPlugin extends JavaPlugin implements GeyserBootstrap {
     private GeyserSpigotConfiguration geyserConfig;
     private GeyserSpigotLogger geyserLogger;
     private IGeyserPingPassthrough geyserSpigotPingPassthrough;
-    private GeyserSpigotBlockPlaceListener blockPlaceListener;
     private GeyserSpigotWorldManager geyserWorldManager;
 
     private GeyserConnector connector;
@@ -125,10 +124,15 @@ public void onEnable() {
         // Used to determine if Block.getBlockData() is present.
         boolean isLegacy = !isCompatible(Bukkit.getServer().getVersion(), "1.13.0");
         if (isLegacy)
-            geyserLogger.debug("Legacy version of Minecraft (1.12.2 or older) detected.");
+            geyserLogger.debug("Legacy version of Minecraft (1.12.2 or older) detected; falling back to ViaVersion for block state retrieval.");
 
-        this.geyserWorldManager = new GeyserSpigotWorldManager(isLegacy, isViaVersion);
-        this.blockPlaceListener = new GeyserSpigotBlockPlaceListener(connector, isLegacy, isViaVersion);
+        boolean use3dBiomes = isCompatible(Bukkit.getServer().getVersion(), "1.16.0");
+        if (!use3dBiomes) {
+            geyserLogger.debug("Legacy version of Minecraft (1.15.2 or older) detected; not using 3D biomes.");
+        }
+
+        this.geyserWorldManager = new GeyserSpigotWorldManager(isLegacy, use3dBiomes, isViaVersion);
+        GeyserSpigotBlockPlaceListener blockPlaceListener = new GeyserSpigotBlockPlaceListener(connector, isLegacy, isViaVersion);
 
         Bukkit.getServer().getPluginManager().registerEvents(blockPlaceListener, this);
 

diff --git a/...rap/spigot/src/main/java/org/geysermc/platform/spigot/world/GeyserSpigotWorldManager.java b/...rap/spigot/src/main/java/org/geysermc/platform/spigot/world/GeyserSpigotWorldManager.java
@@ -25,23 +25,71 @@
 
 package org.geysermc.platform.spigot.world;
 
-import lombok.AllArgsConstructor;
+import com.fasterxml.jackson.databind.JsonNode;
+import it.unimi.dsi.fastutil.ints.Int2IntMap;
+import it.unimi.dsi.fastutil.ints.Int2IntOpenHashMap;
 import org.bukkit.Bukkit;
+import org.bukkit.World;
+import org.bukkit.block.Biome;
 import org.bukkit.block.Block;
+import org.geysermc.connector.GeyserConnector;
 import org.geysermc.connector.network.session.GeyserSession;
 import org.geysermc.connector.network.translators.world.GeyserWorldManager;
 import org.geysermc.connector.network.translators.world.block.BlockTranslator;
+import org.geysermc.connector.utils.FileUtils;
 import org.geysermc.connector.utils.GameRule;
+import org.geysermc.connector.utils.LanguageUtils;
 import us.myles.ViaVersion.protocols.protocol1_13_1to1_13.Protocol1_13_1To1_13;
 import us.myles.ViaVersion.protocols.protocol1_16_2to1_16_1.data.MappingData;
 
-@AllArgsConstructor
+import java.io.InputStream;
+
 public class GeyserSpigotWorldManager extends GeyserWorldManager {
 
     private final boolean isLegacy;
-    // You need ViaVersion to connect to an older server with Geyser.
-    // However, we still check for ViaVersion in case there's some other way that gets Geyser on a pre-1.13 Bukkit server
+    private final boolean use3dBiomes;
+    /**
+     * You need ViaVersion to connect to an older server with Geyser.
+     * However, we still check for ViaVersion in case there's some other way that gets Geyser on a pre-1.13 Bukkit server
+     */
     private final boolean isViaVersion;
+    /**
+     * Stores a list of {@link Biome} ordinal numbers to Minecraft biome numeric IDs.
+     *
+     * Working with the Biome enum in Spigot poses two problems:
+     * 1: The Biome enum values change in both order and names over the years.
+     * 2: There is no way to get the Minecraft biome ID from the name itself with Spigot.
+     * To solve both of these problems, we store a JSON file of every Biome enum that has existed,
+     * along with its 1.16 biome number.
+     *
+     * The key is the Spigot Biome ordinal; the value is the Minecraft Java biome numerical ID
+     */
+    private final Int2IntMap biomeToIdMap = new Int2IntOpenHashMap(Biome.values().length);
+
+    public GeyserSpigotWorldManager(boolean isLegacy, boolean use3dBiomes, boolean isViaVersion) {
+        this.isLegacy = isLegacy;
+        this.use3dBiomes = use3dBiomes;
+        this.isViaVersion = isViaVersion;
+
+        // Load the values into the biome-to-ID map
+        InputStream biomeStream = FileUtils.getResource("biomes.json");
+        JsonNode biomes;
+        try {
+            biomes = GeyserConnector.JSON_MAPPER.readTree(biomeStream);
+        } catch (Exception e) {
+            throw new AssertionError(LanguageUtils.getLocaleStringLog("geyser.toolbox.fail.runtime_java"), e);
+        }
+        // Only load in the biomes that are present in this version of Minecraft
+        for (Biome enumBiome : Biome.values()) {
+            if (biomes.has(enumBiome.toString())) {
+                biomeToIdMap.put(enumBiome.ordinal(), biomes.get(enumBiome.toString()).intValue());
+            } else {
+                GeyserConnector.getInstance().getLogger().debug("No biome mapping found for " + enumBiome.toString() +
+                        ", defaulting to 0");
+                biomeToIdMap.put(enumBiome.ordinal(), 0);
+            }
+        }
+    }
 
     @Override
     public int getBlockAt(GeyserSession session, int x, int y, int z) {
@@ -77,6 +125,43 @@ public static int getLegacyBlock(GeyserSession session, int x, int y, int z, boo
     }
 
     @Override
+    @SuppressWarnings("deprecation")
+    public int[] getBiomeDataAt(GeyserSession session, int x, int z) {
+        if (session.getPlayerEntity() == null) {
+            return new int[1024];
+        }
+        int[] biomeData = new int[1024];
+        World world = Bukkit.getPlayer(session.getPlayerEntity().getUsername()).getWorld();
+        int chunkX = x << 4;
+        int chunkZ = z << 4;
+        int chunkXmax = chunkX + 16;
+        int chunkZmax = chunkZ + 16;
+        // 3D biomes didn't exist until 1.15
+        if (use3dBiomes) {
+            for (int localX = chunkX; localX < chunkXmax; localX += 4) {
+                for (int localY = 0; localY < 255; localY += + 4) {
+                    for (int localZ = chunkZ; localZ < chunkZmax; localZ += 4) {
+                        // Index is based on wiki.vg's index requirements
+                        final int i = ((localY >> 2) & 63) << 4 | ((localZ >> 2) & 3) << 2 | ((localX >> 2) & 3);
+                        biomeData[i] = biomeToIdMap.getOrDefault(world.getBiome(localX, localY, localZ).ordinal(), 0);
+                    }
+                }
+            }
+        } else {
+            // Looks like the same code, but we're not checking the Y coordinate here
+            for (int localX = chunkX; localX < chunkXmax; localX += 4) {
+                for (int localY = 0; localY < 255; localY += + 4) {
+                    for (int localZ = chunkZ; localZ < chunkZmax; localZ += 4) {
+                        // Index is based on wiki.vg's index requirements
+                        final int i = ((localY >> 2) & 63) << 4 | ((localZ >> 2) & 3) << 2 | ((localX >> 2) & 3);
+                        biomeData[i] = biomeToIdMap.getOrDefault(world.getBiome(localX, localZ).ordinal(), 0);
+                    }
+                }
+            }
+        }
+        return biomeData;
+    }
+
     public Boolean getGameRuleBool(GeyserSession session, GameRule gameRule) {
         return Boolean.parseBoolean(Bukkit.getPlayer(session.getPlayerEntity().getUsername()).getWorld().getGameRuleValue(gameRule.getJavaID()));
     }