-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared element prototype #720
Merged
KovalevAndrey
merged 32 commits into
bumble-tech:1.x
from
KovalevAndrey:shared-element-prototype-copy
Jan 8, 2025
Merged
Shared element prototype #720
KovalevAndrey
merged 32 commits into
bumble-tech:1.x
from
KovalevAndrey:shared-element-prototype-copy
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey/appyx into 1.x-shared-element-prototype
Co-authored-by: Manuel Vivo <[email protected]>
Co-authored-by: Manuel Vivo <[email protected]>
…e/Children.kt Co-authored-by: Manuel Vivo <[email protected]>
Co-authored-by: Manuel Vivo <[email protected]>
- Moved LocalMovableContentMap to Children composable and added a parameter to it. - Added support for more movableContent API variants
…ment-prototype-copy
manuelvicnt
approved these changes
Jan 8, 2025
CherryPerry
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shared element transition integration into Appyx. Duplicates #701
withSharedElementTransition: Boolean = true
onChildren
layout when drawing children.sharedElement
Modifier In Node's UI implementation and provide a key that matches the appropriate element's key in the other Node's UI.Added support for movableContent. Now we can "move one part of the composable tree" from one child node to another without losing its state. We can only move content between the Node that is transitioning to invisible state to the Node that is transitioning to visible state because movable content is meant to be composed only once at any time. For instance:
NodeA
is currently shown in aBackStack
and we pushNodeB
toBackStack
. In this case we can move content fromNodeA
toNodeB
. To move the content we need to uselocalMovableContentWithTargetVisibility
with the correct key in each child Node.Screen_recording_20240429_204738.mp4
Checklist
CHANGELOG.md
if required.