Do not change selection to update lists #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshad1
commented
Jan 26, 2024
| let l:prev_indent = -1 | ||
| let l:levels = {} " stores all the info about the current outline/list | ||
|
|
||
| for l:line in l:selection_lines |
There was a problem hiding this comment.
We are using just the line numbers anyway so a loop is sufficient
harshad1
commented
Jan 26, 2024
| " Reset the starting visual selection | ||
| call setpos("'<", [0, a:1[0], a:1[1], 0]) | ||
| call setpos("'>", [0, a:2[0], a:2[1], 0]) | ||
| execute 'normal! gv' |
There was a problem hiding this comment.
We don't need any of the reset visual selection code
harshad1
commented
Jan 26, 2024
| " Iterate the cursor position over each line and then call | ||
| " s:change_bullet_level for that cursor position. | ||
| call setpos('.', [0, l:lnum, 1, 0]) | ||
| call s:change_bullet_level(a:direction) |
There was a problem hiding this comment.
Just pass in the number to save on a lot of unnecessary work
harshad1
commented
Jan 26, 2024
| if g:bullets_renumber_on_change | ||
| " Pass the current visual selection so that it gets reset after | ||
| " renumbering the list. | ||
| call s:renumber_whole_list(l:start, l:end) |
harshad1
commented
Jan 26, 2024
| @@ -1089,9 +1075,10 @@ fun! s:get_visual_selection_lines() | |||
| let l:index = l:lnum1 | |||
| let l:lines_with_index = [] | |||
| for l:line in l:lines | |||
| let l:lines_with_index += [{'text': l:line, 'nr': l:index}] | |||
There was a problem hiding this comment.
This is an optimisation.
However, the entire get_visual_selection_lines() is not needed anymore and perhaps ought to be removed.
harshad1
changed the title
harshad1
commented
Jan 29, 2024
| " When setting the selection we set the start and end at the same _offset_ | ||
| " From the new line start and end. As we manipulate line prefixes, the | ||
| " offset from the end represents the correct new cursor position | ||
| fun! s:get_selection(is_visual) |
There was a problem hiding this comment.
We need to pass in is_visual because this state is lost by the time the function is triggered.
|
This is ready to merge |
kaymmm
added a commit
to kaymmm/bullets.nvim
that referenced
this pull request
Feb 18, 2024
copied from bullets-vim/bullets.vim#145 By harshad1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have modified several functions to eliminate the need for modifying the current selection or cursor position.
This results in:
I have also added logic to explicitly save the cursor / selection position and have it restored after the change.